This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Your new binutils ld tests broke cris-elf without installed target compiler
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: gingold at adacore dot com
- Cc: hans-peter dot nilsson at axis dot com, ebotcazou at adacore dot com, binutils at sourceware dot org
- Date: Fri, 11 Jan 2008 18:09:45 +0100
- Subject: Re: Your new binutils ld tests broke cris-elf without installed target compiler
> From: Tristan Gingold <gingold@adacore.com>
> Date: Fri, 11 Jan 2008 17:27:41 +0100
> Ok, so second try:
>
> ld/testsuite:
> 2008-01-11 Tristan Gingold <gingold@adacore.com>
>
> * ld-gc/gc.exp (test_gc): Missing C compiler makes tests untested
> instead of failed.
Generally looks ok, but your mailer botches tabs and...
> *** ld/testsuite/ld-gc/gc.exp 11 Jan 2008 09:11:18 -0000 1.1
> if ![ld_simple_link $linker $outfile "-L$srcdir/$subdir
> $ldflags $objfile"] {
> ! fail $testname
... I removed this spurious (and wrong) indentation part of the
patch when I tested. Actually I just edited the original
gc.exp, as in the following diff:
--- x/binutils_checkout/ld/testsuite/ld-gc/gc.exp Fri Jan 11 10:11:18 2008
+++ ./gc.exp Fri Jan 11 17:50:35 2008
@@ -27,7 +27,9 @@ if ![check_gc_sections_available] {
set cflags "-ffunction-sections -fdata-sections"
set objfile "tmpdir/gc.o"
-ld_compile "$CC -c $CFLAGS $cflags" $srcdir/$subdir/gc.c $objfile
+if { [is_remote host] || [which $CC] } {
+ ld_compile "$CC -c $CFLAGS $cflags" $srcdir/$subdir/gc.c $objfile
+}
proc test_gc { testname filename linker ldflags} {
global nm
@@ -35,6 +37,11 @@ proc test_gc { testname filename linker
global subdir
global nm_output
global objfile
+
+ if ![file readable $objfile ] {
+ untested $testname
+ return
+ }
set outfile "tmpdir/$filename"
thanks.
brgds, H-P