Re: [PATCH] fix DWARF for ia64

[Nick Clifton <nickc at redhat dot com>]

Hi Bob,

> Here is a follow-on patch.  I noticed that dwarf2_emit_label() can also 
> use the new dwarf2_consume_line_info function.
>
> Is this OK?

Your first patch and this follow on one both look OK, apart from the last part 
of this second patch:

     loc.flags |= DWARF2_FLAG_BASIC_BLOCK;

  -  current.flags &= ~(DWARF2_FLAG_BASIC_BLOCK
  -		     | DWARF2_FLAG_PROLOGUE_END
  -		     | DWARF2_FLAG_EPILOGUE_BEGIN);
  -
  +  dwarf2_consume_line_info ();
     dwarf2_gen_line_info_1 (label, &loc);

Why are you deleting the update of current.flags ?


> Everything passed as expected with one 
> exception: the ld-ia64/line.exp test fails but I see the same failure 
> without any of my changes.

Hmm, I do not see that failure.  In fact I get (trimmed slightly for email):

  Running .../ld-ia64/line.exp ...
  .../gas/as-new -o tmpdir/undefined.o -x .../ld-ia64/undefined.s
  ./ld-new -e start -o tmpdir/undefined tmpdir/undefined.o
  ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0
  tmpdir/undefined.o: In function `function':
  undefined.c:9: undefined reference to `this_function_is_not_defined'
  ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0
  tmpdir/undefined.o: In function `function':
  undefined.c:9: undefined reference to `this_function_is_not_defined'
  ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0
  tmpdir/undefined.o: In function `function':
  undefined.c:9: undefined reference to `this_function_is_not_defined'
  PASS: undefined line
  testcase .../ld-ia64/line.exp completed in 0 seconds

> ld fails to show the source line number in 
> an error message.  That does seem suspicious.  Is this a known problem?

Suspicious yes.  Known problem no.  The above test was run for an 
ia64-unknown-linux-gnu toolchain, and I would hope that you would see the same 
results.  Can you investigate a little more please ?

Cheers
  Nick