This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add x86 SSE5 instructions to the GNU binary utilities

On Fri, Sep 14, 2007 at 10:45:22AM -0500, rajagopal, dwarak wrote:
> I thought the restriction was 80 columns instead of 72.
> Nevertheless, I have fixed all my changes to 72 columns. Also, I have
> fixed all other comments you pointed out.
> 
> Ok?
> 

-      if (i.tm.extension_opcode != None)
+      if (i.tm.extension_opcode != None
+	  && (i.tm.opcode_modifier.drex 
+	      || i.tm.opcode_modifier.drexv 
+	      || i.tm.opcode_modifier.drexc) == 0)

Please change it to !() instead of == 0.  OK with this change.

Thanks.


H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]