This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, MIPS] Better diagnostic on incorrect size for .reginfo
Maciej W. Rozycki writes:
> On Tue, 14 Aug 2007, Adam Nemet wrote:
>
> > N64 does not have .reginfo so I am not sure that running this test
> > unconditionally is a good idea. Should I only run this if !$newabi?
> > It seems that all the newabi targets actually default to N32 so maybe
> > it is safe.
>
> You should probably request the ABI(s) you want to test explicitly.
For $newabi targets I am forcing n32 now. This seems to be in sync
with current practice (e.g. reloc-1-n32). Maciej, Is this close
enough to what you had in mind?
Thiemo, OK to install?
Adam
* ld-mips-elf/reginfo-size.s, ld-mips-elf/reginfo-size.ld,
ld-mips-elf/reginfo-size-n32.ld, ld-mips-elf/reginfo-size.d,
ld-mips-elf/reginfo-size-n32.d: New tests.
* ld-mips-elf/mips-elf.exp: Run them.
Index: ld-mips-elf/mips-elf.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-mips-elf/mips-elf.exp,v
retrieving revision 1.47
diff -F^\([(a-zA-Z0-9_]\|#define\) -u -p -r1.47 mips-elf.exp
--- ld-mips-elf/mips-elf.exp 13 Aug 2007 21:16:39 -0000 1.47
+++ ld-mips-elf/mips-elf.exp 15 Aug 2007 19:02:33 -0000
@@ -297,3 +297,10 @@ run_dump_test "attr-gnu-4-31"
run_dump_test "attr-gnu-4-32"
run_dump_test "attr-gnu-4-33"
run_dump_test "attr-gnu-4-41"
+
+# N64 doesn't have .reginfo, force n32.
+if $has_newabi {
+ run_dump_test "reginfo-size-n32"
+} else {
+ run_dump_test "reginfo-size"
+}
Index: ld-mips-elf/reginfo-size-n32.d
===================================================================
RCS file: ld-mips-elf/reginfo-size-n32.d
diff -N ld-mips-elf/reginfo-size-n32.d
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ ld-mips-elf/reginfo-size-n32.d 15 Aug 2007 19:02:33 -0000
@@ -0,0 +1,3 @@
+#source: reginfo-size.s -mabi=n32
+#ld: -Treginfo-size-n32.ld
+#error: .reginfo is .* bytes instead of .* bytes
Index: ld-mips-elf/reginfo-size-n32.ld
===================================================================
RCS file: ld-mips-elf/reginfo-size-n32.ld
diff -N ld-mips-elf/reginfo-size-n32.ld
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ ld-mips-elf/reginfo-size-n32.ld 15 Aug 2007 19:02:33 -0000
@@ -0,0 +1,4 @@
+SECTIONS
+{
+ .reginfo ALIGN(8) + 4 : { *(.reginfo) }
+}
Index: ld-mips-elf/reginfo-size.d
===================================================================
RCS file: ld-mips-elf/reginfo-size.d
diff -N ld-mips-elf/reginfo-size.d
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ ld-mips-elf/reginfo-size.d 15 Aug 2007 19:02:33 -0000
@@ -0,0 +1,3 @@
+#source: reginfo-size.s
+#ld: -Treginfo-size.ld
+#error: .reginfo is .* bytes instead of .* bytes
Index: ld-mips-elf/reginfo-size.ld
===================================================================
RCS file: ld-mips-elf/reginfo-size.ld
diff -N ld-mips-elf/reginfo-size.ld
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ ld-mips-elf/reginfo-size.ld 15 Aug 2007 19:02:33 -0000
@@ -0,0 +1,4 @@
+SECTIONS
+{
+ .reginfo ALIGN(4) + 2 : { *(.reginfo) }
+}
Index: ld-mips-elf/reginfo-size.s
===================================================================
RCS file: ld-mips-elf/reginfo-size.s
diff -N ld-mips-elf/reginfo-size.s
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ ld-mips-elf/reginfo-size.s 15 Aug 2007 19:02:33 -0000
@@ -0,0 +1 @@
+ nop