This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: loadbase alignment - ld.so/prelink/kernel or bfd_elf_bfd_from_remote_memory() bug?
On Wed, Aug 15, 2007 at 07:45:04AM -0700, H.J. Lu wrote:
> On Wed, Aug 15, 2007 at 04:40:55PM +0200, Jan Kratochvil wrote:
> > On Wed, 15 Aug 2007 16:03:02 +0200, H.J. Lu wrote:
> > > On Wed, Aug 15, 2007 at 03:56:10PM +0200, Jan Kratochvil wrote:
> > ...
> > > > --- glibc-20070810T2152-orig/elf/dl-load.c 2007-08-03 17:50:24.000000000 +0200
> > > > +++ glibc-20070810T2152/elf/dl-load.c 2007-08-15 00:41:03.000000000 +0200
> > > > @@ -1012,6 +1012,7 @@ _dl_map_object_from_fd (const char *name
> > > > int prot;
> > > > } loadcmds[l->l_phnum], *c;
> > > > size_t nloadcmds = 0;
> > > > + ElfW(Addr) alignmax = GLRO(dl_pagesize);
> > >
> > > Why not replace all GLRO(dl_pagesize) with alignmax?
> >
> > Sorry if I did not understand your suggestion.
> >
>
> You introduced alignmax for GLRO(dl_pagesize). But you still use
> GLRO(dl_pagesize) in some places instead of alignmax.
Never mind.
H.J.