This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: patch: Updated windres tool Part 1 of 2
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: "Dave Korn" <dave dot korn at artimi dot com>
- Cc: "'Binutils'" <binutils at sourceware dot org>, "'Danny Smith'" <dannysmith at clear dot net dot nz>, "'Nick Clifton'" <nickc at redhat dot com>
- Date: Tue, 22 May 2007 16:44:32 +0200
- Subject: RE: patch: Updated windres tool Part 1 of 2
"Dave Korn" <dave.korn@artimi.com> wrote on 22.05.2007 16:39:03:
> On 22 May 2007 15:32, Nick Clifton wrote:
>
> > Hi Kai,
> >
> >> I am really uncertain about this. The fix is quite simple by
allocating
> >> the output buffer using a 4 bytes alignment in "resres.c".
> >
> > Lets do that then. (Fewer changes to other files == better in my
opinion).
> >
> >>> /* Use bfd_size_type to ensure a sufficient number of bits. */
> >>> typedef rc_bitfield_type bfd_size_type;
> >
> >> This sounds fine. I am agreeing to that. I will walk over the code
for
> >> this. I would prefer as name something like rc_int_type. Is that ok ?
> >
> > Yes this is fine. My name was just a suggestion.
>
> The name should probably convey whether it's signed or not, shouldn't
it?
> Size types are usually unsigned - perhaps rc_uint_type would be best of
all?
Fine ;)
Cheers,
i.A. Kai Tietz
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
------------------------------------------------------------------------------------------
OneVision Software Entwicklungs GmbH & Co. KG
Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
Handelsregister: HRA 6744, Amtsgericht Regensburg
KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer:
Ulrike DÃhler, Manuela Kluger