This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: Updated windres tool Part 1 of 2


Hi Kai,

I am really uncertain about this. The fix is quite simple by allocating the output buffer using a 4 bytes alignment in "resres.c".

Lets do that then. (Fewer changes to other files == better in my opinion).


   /* Use bfd_size_type to ensure a sufficient number of bits.  */
   typedef rc_bitfield_type bfd_size_type;

This sounds fine. I am agreeing to that. I will walk over the code for this. I would prefer as name something like rc_int_type. Is that ok ?

Yes this is fine. My name was just a suggestion.


Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]