This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Handle multiple ELF function types.
- From: Andreas Schwab <schwab at suse dot de>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 04 Apr 2007 00:55:57 +0200
- Subject: Re: [patch] Handle multiple ELF function types.
- References: <200704032334.37520.paul@codesourcery.com>
Paul Brook <paul@codesourcery.com> writes:
> @@ -961,7 +962,9 @@ _bfd_elf_merge_symbol (bfd *abfd,
> && (olddef || h->root.type == bfd_link_hash_common)
> && ELF_ST_TYPE (sym->st_info) != h->type
> && ELF_ST_TYPE (sym->st_info) != STT_NOTYPE
> - && h->type != STT_NOTYPE)
> + && h->type != STT_NOTYPE
> + && !(bed->is_function_type(ELF_ST_TYPE (sym->st_info))
> + && bed->is_function_type(h->type)))
Style nit: space missing before the open paren in the function call.
> @@ -1152,6 +1155,11 @@ _bfd_elf_merge_symbol (bfd *abfd,
> if (olddef && newdyn)
> oldweak = FALSE;
>
> + /* Allow changes between different types of funciton symbol. */
> + if (bed->is_function_type(ELF_ST_TYPE (sym->st_info))
> + && bed->is_function_type(h->type))
Likewise.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."