This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: A question on ACX_BUGURL

> +      no)  BUGURL="";

just BUGURL= (no useless trailing semicolon).

> +  case ${BUGURL} in

Please quote this as "$BUGURL".

> +    REPORT_BUGS_TO="<$BUGURL>"
> +    REPORT_BUGS_TEXI="@uref{`echo $BUGURL | sed 's/@/@@/g'`}"

Please do this instead:

  REPORT_BUGS_TEXI=@uref{`echo "$BUGURL" | sed 's/@/@@/g'`}

as suggested by Andreas.  Quoting is "less" necessary in variable
assignments (it is still necessary for REPORT_BUGS_TO because
of the less-than/greater-than signs).

Otherwise seems okay, but please resubmit.

Paolo
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]