This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Move i386 opcode to opcodes/i386-opc.c

"H. J. Lu" <hjl@lucon.org> writes:

> On Wed, Mar 21, 2007 at 03:01:39PM +0100, Andreas Schwab wrote:
>> "H. J. Lu" <hjl@lucon.org> writes:
>> 
>> > NOP_OPCODE is defined in opcode/i386.h.
>> 
>> But it still lacks a comment.
>> 
>
> The opcode of nop instruction for x86 is 0x90. NOP_OPCODE shouldn't
> be defined to something else.

The lack of a comment has already broken the assembler.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]