This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/3966: 32bit address wrap around doesn't work with 32bit host
On Tue, Feb 06, 2007 at 09:57:20AM -0500, Hans-Peter Nilsson wrote:
> On Wed, 7 Feb 2007, Alan Modra wrote:
> > * ldlang.c (lang_size_sections_1): Don't warn on backwards dot
> > move unless section size is non-zero.
>
> > @@ -4463,8 +4463,11 @@ lang_size_sections_1
> > || (os->bfd_section->flags & SEC_THREAD_LOCAL) == 0)
> > && (os->bfd_section->flags & SEC_ALLOC) != 0
> > && (os->bfd_section->size != 0
> > - || os->bfd_section->vma != os->bfd_section->lma
> > - || r->last_os != NULL)
> > + || (r->last_os == NULL
> > + && os->bfd_section->vma != os->bfd_section->lma)
> > + || (r->last_os != NULL
> > + && dot >= (r->last_os->output_section_statement
> > + .bfd_section->vma))
>
> Forgot to compile and test? Mismatching parentheses.
> (My autotester blew up.)
>
I checked in the following patch.
H.J.
----
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/ld/ChangeLog,v
retrieving revision 1.1651
diff -u -p -r1.1651 ChangeLog
--- ChangeLog 6 Feb 2007 13:56:38 -0000 1.1651
+++ ChangeLog 6 Feb 2007 16:03:09 -0000
@@ -1,5 +1,10 @@
+2007-02-06 H.J. Lu <hongjiu.lu@intel.com>
+
+ * ldlang.c (lang_size_sections_1): Add a missing `)'.
+
2007-02-06 Alan Modra <amodra@bigpond.net.au>
+ PR ld/3966
* ldlang.c (lang_size_sections_1): Don't warn on backwards dot
move unless section size is non-zero.
Index: ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.249
diff -u -p -r1.249 ldlang.c
--- ldlang.c 6 Feb 2007 13:56:38 -0000 1.249
+++ ldlang.c 6 Feb 2007 16:03:13 -0000
@@ -4468,7 +4468,7 @@ lang_size_sections_1
&& os->bfd_section->vma != os->bfd_section->lma)
|| (r->last_os != NULL
&& dot >= (r->last_os->output_section_statement
- .bfd_section->vma))
+ .bfd_section->vma)))
&& os->lma_region == NULL
&& !link_info.relocatable)
r->last_os = s;