This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: fx_plt
- From: Bob Wilson <bwilson at tensilica dot com>
- To: binutils at sources dot redhat dot com
- Date: Thu, 01 Feb 2007 15:56:28 -0800
- Subject: Re: fx_plt
It looks to me like the Xtensa code using fx_plt was completely redundant, so
I've taken it out.
2007-02-01 Bob Wilson <bob.wilson@acm.org>
* config/tc-xtensa.c (xg_add_opcode_fix, md_apply_fix): Delete use of
fx_tcbit.
* config/tc-xtensa.h (TC_FORCE_RELOCATION_LOCAL): Remove.
Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.73
diff -u -p -r1.73 tc-xtensa.c
--- config/tc-xtensa.c 1 Feb 2007 14:12:18 -0000 1.73
+++ config/tc-xtensa.c 1 Feb 2007 23:36:22 -0000
@@ -1,5 +1,5 @@
/* tc-xtensa.c -- Assemble Xtensa instructions.
- Copyright 2003, 2004, 2005, 2006 Free Software Foundation, Inc.
+ Copyright 2003, 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@@ -4114,12 +4114,6 @@ xg_add_opcode_fix (TInsn *tinsn,
the_fix = fix_new_exp (fragP, offset, fmt_length, expr,
howto->pc_relative, reloc);
the_fix->fx_no_overflow = 1;
-
- if (expr->X_add_symbol
- && (S_IS_EXTERNAL (expr->X_add_symbol)
- || S_IS_WEAK (expr->X_add_symbol)))
- the_fix->fx_tcbit = TRUE;
-
the_fix->tc_fix_data.X_add_symbol = expr->X_add_symbol;
the_fix->tc_fix_data.X_add_number = expr->X_add_number;
the_fix->tc_fix_data.slot = slot;
@@ -5567,7 +5561,6 @@ md_apply_fix (fixS *fixP, valueT *valP,
assert (fixP->fx_addsy);
if (S_GET_SEGMENT (fixP->fx_addsy) == seg
- && !fixP->fx_tcbit
&& !S_FORCE_RELOC (fixP->fx_addsy, 1))
{
val = (S_GET_VALUE (fixP->fx_addsy) + fixP->fx_offset
Index: config/tc-xtensa.h
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.h,v
retrieving revision 1.21
diff -u -p -r1.21 tc-xtensa.h
--- config/tc-xtensa.h 1 Feb 2007 14:12:20 -0000 1.21
+++ config/tc-xtensa.h 1 Feb 2007 23:36:22 -0000
@@ -1,5 +1,5 @@
/* tc-xtensa.h -- Header file for tc-xtensa.c.
- Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc.
+ Copyright (C) 2003, 2004, 2005, 2007 Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@@ -319,10 +319,6 @@ extern char *xtensa_section_rename (char
#define TC_FORCE_RELOCATION(fix) xtensa_force_relocation (fix)
#define TC_FORCE_RELOCATION_SUB_SAME(fix, seg) \
(! SEG_NORMAL (seg) || xtensa_force_relocation (fix))
-#define TC_FORCE_RELOCATION_LOCAL(FIX) \
- (!(FIX)->fx_pcrel \
- || (FIX)->fx_tcbit \
- || TC_FORCE_RELOCATION (FIX))
#define TC_VALIDATE_FIX_SUB(fix) xtensa_validate_fix_sub (fix)
#define NO_PSEUDO_DOT xtensa_check_inside_bundle ()
#define tc_canonicalize_symbol_name(s) xtensa_section_rename (s)