Re: [PATCH] Fix Score bugs.

["H. J. Lu" <hjl at lucon dot org>]

On Thu, Jan 18, 2007 at 06:37:57PM +0800, ligang@sunnorth.com.cn wrote:
> Hi all,
> 
> Fix some bugs.
> 

Please mention PR 3871 in ChangeLog and remove _() from:

bash-3.1$ egrep "_\([^\"]"  tc-score.c
          inst.error = _(err_msg);
          inst.error = _(err_msg);
          inst.error = _(err_msg);
                  inst.error = _(err_msg);
      inst.error = _(err_msg);

There is no ChangeLog for ls32ls16.d.

> ChangeLog
> 
> 2007-01-18  Mei Ligang  <ligang@sunnorth.com.cn>
> 
>         * config/tc-score.c : Using _() for const string.
>         Do not assign inst.error with a local string pointer.
>         (md_section_align): Pad section.
> 
> 
> Index: tc-score.c
> ===================================================================
> RCS file: /cvs/src/src/gas/config/tc-score.c,v
> retrieving revision 1.7
> diff -p -u -r1.7 tc-score.c
> --- tc-score.c  25 Dec 2006 09:26:22 -0000      1.7
> +++ tc-score.c  18 Jan 2007 09:41:46 -0000
> @@ -535,7 +535,7 @@ static const struct asm_opcode score_ins
>    {"lh!",       0x2009,     0x700f,     0x22000000, Rd_rvalueRs, 
> do16_ldst_insn},

Please make sure your patch isn't wrapped around.

>    {"lhp!",      0x7001,     0x7007,     0x22000000, Rd_rvalueBP_I5, 
> do16_ldst_imm_insn},
>    {"ldi",       0x020c0000, 0x3e0e0000, 0x5000,     Rd_SI16, do_rdsi16},
> -  {"ldis",      0x0a0c0000, 0x3e0e0000, 0x5000,     Rd_I16, do_rdi16},
> +  {"ldis",      0x0a0c0000, 0x3e0e0000, 0x8000,     Rd_I16, do_rdi16},

There is no ChangeLog entry for this.

> @@ -2395,7 +2396,7 @@ append_insn (char *str, bfd_boolean gen_
>    if (inst.error)
>      {
>        retval = (int) FAIL;
> -      as_bad ("%s -- `%s'", inst.error, inst.str);
> +      as_bad (_("%s -- `%s'"), inst.error, inst.str);

_() isn't needed here.

>        inst.error = NULL;
>      }
>  
> @@ -2437,7 +2438,7 @@ do16_mv_rdrs (char *str)
>              {
>                char append_str[MAX_LITERAL_POOL_SIZE];
>  
> -              sprintf (append_str, "mlfh! %s", backupstr);
> +              sprintf (append_str, _("mlfh! %s"), backupstr);

I don't think _() is needed for mnemonics. Please fix them.

>  
> Index: ls32ls16.d
> ===================================================================
> RCS file: /cvs/src/src/gas/testsuite/gas/score/ls32ls16.d,v
> retrieving revision 1.1
> diff -r1.1 ls32ls16.d
> 144a145
> > #pass
> 
> Best regards
>                      Ligang


H.J.