This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: silence warnings in gprof/corefile.c

From: Nick Clifton <nickc at redhat dot com>
To: Ben Elliston <bje at au1 dot ibm dot com>
Cc: binutils at sourceware dot org
Date: Mon, 15 Jan 2007 08:42:32 +0000
Subject: Re: PATCH: silence warnings in gprof/corefile.c
References: <1168832380.5957.2.camel@localhost>

Hi Ben,

2007-01-15 Ben Elliston <bje@au.ibm.com>

        * corefile.c (read_function_mappings): Check calls to fscanf and
        report any errors in parsing the mapping file.

Approved - please apply - although since you are repeating the same block of code four times, wouldn't it be easier to put the new code into a function or macro and just call that four times ?

Cheers
  Nick

Follow-Ups:
- Re: PATCH: silence warnings in gprof/corefile.c
  - From: Ben Elliston

References:
- PATCH: silence warnings in gprof/corefile.c
  - From: Ben Elliston

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]