This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Add fido support (Part 5/n)
- From: Andreas Schwab <schwab at suse dot de>
- To: Kazu Hirata <kazu at codesourcery dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 26 Dec 2006 12:01:12 +0100
- Subject: Re: [patch] Add fido support (Part 5/n)
- References: <200612252344.kBPNi9BE031415@sparrowhawk.codesourcery.com>
Kazu Hirata <kazu@codesourcery.com> writes:
> gas/
> 2006-12-25 Kazu Hirata <kazu@codesourcery.com>
>
> * config/tc-m68k.c (m68k_ip): Do something.
That needs to be a bit more descriptive. :-)
> Index: gas/config/tc-m68k.c
> ===================================================================
> RCS file: /cvs/src/src/gas/config/tc-m68k.c,v
> retrieving revision 1.80
> diff -u -d -p -r1.80 tc-m68k.c
> --- gas/config/tc-m68k.c 25 Dec 2006 22:39:21 -0000 1.80
> +++ gas/config/tc-m68k.c 25 Dec 2006 22:40:19 -0000
> @@ -1134,6 +1134,21 @@ m68k_ip (char *instring)
> opcode = (const struct m68k_incant *) hash_find (op_hash, instring);
> *p = c;
>
> + /* Fido does not support certain instructions. Warn about uses
> + of those instructions. */
> + if ((cpu_of_arch (current_architecture) & fido_a) != 0)
> + {
> + /* Recognize tbl[su]{n,}[bwl]. */
> + if (strncmp (instring, "tbl", 3) == 0
> + && (instring[3] == 's' || instring[3] == 'u')
> + && ((strchr ("bwl", instring[4]) != 0
> + && instring[5] == '\0')
> + || (instring[4] == 'n'
> + && strchr ("bwl", instring[5]) != 0
> + && instring[6] == '\0')))
> + as_warn (_("'%s' not supported on Fido"), instring);
> + }
> +
IMHO it would be better to fix the opcode table so that the unsupported
insns don't match in the first place.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."