This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: toplevel commits [was Re: Fix make -j4 installs]
- From: DJ Delorie <dj at redhat dot com>
- To: amodra at bigpond dot net dot au
- Cc: gcc-patches at gcc dot gnu dot org, binutils at sourceware dot org
- Date: Fri, 8 Dec 2006 08:08:26 -0500
- Subject: Re: toplevel commits [was Re: Fix make -j4 installs]
- References: <200612080316.kB83GgXP005627@greed.delorie.com> <200612080325.kB83Pafc013531@localhost.localdomain> <20061208065639.GN11647@bubble.grove.modra.org>
> That reminds me. It's even a make -j problem, so fits under this
> thread. DJ, would you please review the following patch? There's an
> alternate patch in a followup.
>
> http://gcc.gnu.org/ml/gcc-patches/2006-10/msg01262.html
I don't like the syntax of that particular patch; I'd rather see an
explicit if/then/fi than use && to conditionalize such a large chunk
(the case statement). Otherwise it just looks weird.
The MAINT follow up is wrong; Makefile.in is generated so you have to
work through the Makefile.tpl and Makefile.def files. Otherwise, the
syntax is fine.
I don't think we're unconditionally moving away from Makefile
fragments, but we're trying to restrict them to cases where it really
makes sense, and use them wisely. This is clearly one of those cases.
So this patch is OK if it's fixed to use the tpl/def files:
http://gcc.gnu.org/ml/gcc-patches/2006-10/msg01314.html