This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Clean up SSE disassembler
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <jbeulich at novell dot com>
- Cc: dwarak dot rajagopal at amd dot com, michael dot meissner at amd dot com, binutils at sourceware dot org
- Date: Fri, 10 Nov 2006 06:20:05 -0800
- Subject: Re: PATCH: Clean up SSE disassembler
- References: <20061109192802.GA32611@lucon.org> <45544371.76E4.0078.0@novell.com>
On Fri, Nov 10, 2006 at 09:16:33AM +0100, Jan Beulich wrote:
> >--- binutils/gas/testsuite/gas/i386/sse2.d.sse 2006-08-14 16:45:59.000000000 -0700
> >+++ binutils/gas/testsuite/gas/i386/sse2.d 2006-11-09 11:10:43.000000000 -0800
> >@@ -142,7 +142,7 @@ Disassembly of section .text:
> > 241: 66 0f 6f c8[ ]+movdqa %xmm0,%xmm1
> > 245: 66 0f 6f c8[ ]+movdqa %xmm0,%xmm1
> > 249: f3 0f 6f c8[ ]+movdqu %xmm0,%xmm1
> >- 24d: f3 0f 6f c8[ ]+movdqu %xmm0,%xmm1
> >+ 24d: f3 0f 7f 06[ ]+movdqu %xmm0,\(%esi\)
> > 251: f2 0f d6 c8[ ]+movdq2q %xmm0,%mm1
> > 255: f3 0f d6 c8[ ]+movq2dq %mm0,%xmm1
> > 259: 66 0f f4 c8[ ]+pmuludq %xmm0,%xmm1
> >--- binutils/gas/testsuite/gas/i386/sse2.s.sse 2001-05-12 02:52:40.000000000 -0700
> >+++ binutils/gas/testsuite/gas/i386/sse2.s 2006-11-09 11:06:52.000000000 -0800
> >@@ -134,7 +134,7 @@ foo:
> > movdqa %xmm0, %xmm1
> > movdqa %xmm0, %xmm1
> > movdqu %xmm0, %xmm1
> >- movdqu %xmm0, %xmm1
> >+ movdqu %xmm0, (%esi)
> > movdq2q %xmm0, %mm1
> > movq2dq %mm0, %xmm1
> > pmuludq %xmm0, %xmm1
>
> While you're at this - why don't you also change the duplicate movdqa
> in the same way?
Done.
H.J.