This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Some Score bugs have been fixed
Hi Ligang,
Hi Nick, BTW, would you please give me the write access to cvs repository?
Now :-) Please fill in the form at:
http://sourceware.org/cgi-bin/pdw/ps_form.cgi
using my name as the sponsor.
1. Fix optimizion of not! instruction.
gas/config/
* tc-score.c (do16_rdrs): Handle not! instruction especially.
gas/testsuite/gas/score/
* rD_rA.d: Correct not! and not.c instruction disassembly.
2. Correct j and b instruction disassembly.
opcodes/
* score-opc.h (score_opcodes): Delete modifier '0x'.
Approved and applied.
Note - patch 2 introduced a new failure into the score specific part of
the gas testsuite, so I applied the attached patch to fix it.
Cheers
Nick
PS. As a side note, it is helpful if you include the body of a patch as
an attachment, rather than just part of the normal email. Some
emailers tend to modify the text inside an email (for example expanding
tabs into spaces) which can corrupt the patch.
Index: gas/testsuite/gas/score/b.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/score/b.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 b.d
*** gas/testsuite/gas/score/b.d 17 Sep 2006 14:24:56 -0000 1.1
--- gas/testsuite/gas/score/b.d 1 Nov 2006 10:28:57 -0000
***************
*** 7,18 ****
Disassembly of section \.text:
00000000 <L1>:
! 0: 4f00 b! 0x0 <L1>
! 2: 4fff b! 0x0 <L1>
! 4: 4ffe b! 0x0 <L1>
! 6: 4ffd b! 0x0 <L1>
! 8: 4ffc b! 0x0 <L1>
! a: 4ffb b! 0x0 <L1>
! c: 93ffbff4 b 0x0 <L1>
10: 8254e010 add r18, r20, r24
#pass
--- 7,18 ----
Disassembly of section \.text:
00000000 <L1>:
! 0: 4f00 b! 0 <L1>
! 2: 4fff b! 0 <L1>
! 4: 4ffe b! 0 <L1>
! 6: 4ffd b! 0 <L1>
! 8: 4ffc b! 0 <L1>
! a: 4ffb b! 0 <L1>
! c: 93ffbff4 b 0 <L1>
10: 8254e010 add r18, r20, r24
#pass