This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] First Cell PPU patch

From: Alan Modra <amodra at bigpond dot net dot au>
To: Andrew_Pinski at PlayStation dot Sony dot Com
Cc: binutils at sourceware dot org, Trevor_Smigiel at PlayStation dot Sony dot com
Date: Sat, 21 Oct 2006 13:11:32 +0930
Subject: Re: [PATCH] First Cell PPU patch
References: <OF107EF537.CD0BC160-ON8825720E.0001338C-8825720E.00052032@playstation.sony.com>

On Fri, Oct 20, 2006 at 05:55:59PM -0700, Andrew_Pinski@PlayStation.Sony.Com wrote:
> opcodes/ChangeLog:
> 2006-10-20  Andrew Pinski  <andrew_pinski@playstation.sony.com>
> 
>         * ppc-opc.c (CELL): New define.
>         (powerpc_opcodes): Enable hrfid and popcntb
>         for Cell.
>         * ppc-dis.c (powerpc_dialect): Handle cell.
> 
> include/opcode/ChangeLog:
> 2006-10-20  Andrew Pinski  <andrew_pinski@playstation.sony.com>
> 
>         * ppc.h (PPC_OPCODE_CELL): Add.
>  
> gas/ChangeLog:
> 2006-10-20  Andrew Pinski  <andrew_pinski@playstation.sony.com>
> 
>         * doc/c-ppc.texi (-mcell): Document.
>         * config/tc-ppc.c (parse_cpu): Parse -mcell.
>         (md_show_usage): Document -mcell.

OK, except

+/* Opcode is only supported by PowerPC Cell family.  */
+#define PPC_OPCODE_CELL		 0x6000000

Typo, should be 0x8000000

Also, shouldn't you add "frsqrtes" and "frsqrtes." to the list of cell
insns?

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Follow-Ups:
- Re: [PATCH] First Cell PPU patch
  - From: Andrew_Pinski
- Re: [PATCH] First Cell PPU patch
  - From: Andrew_Pinski

References:
- [PATCH] First Cell PPU patch
  - From: Andrew_Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]