This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS bfd: Don't place TLS symbols in .scommon
Alan Modra wrote:
> On Mon, Aug 14, 2006 at 01:20:24PM +0100, Thiemo Seufer wrote:
> > * elfxx-mips.c (_bfd_mips_elf_symbol_processing,
> > _bfd_mips_elf_add_symbol_hook): Don't try to place small common TLS
> > symbols in .scommon.
>
> Hmm, why didn't the test in elflink.c stop this happening?
>
> if (isym->st_shndx == SHN_COMMON
> && ELF_ST_TYPE (isym->st_info) == STT_TLS
> && !info->relocatable)
> {
> ..
> }
> else if (bed->elf_add_symbol_hook)
>
> Is this on a relocatable link?
Yes.
> If so, should the mips backend really be
> fiddling with symbols for a relocatable link?
It places small enough common symbols automagically in .scommon instead
of .common. I think it should continue to do that. The behaviour was
inherited from IRIX5, Alpha does the same.
Hm, Alpha might need a similiar fix then.
Thiemo