This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Allow fdaddl %dX,%fpY on Coldfire


> The patch fixes the opcodes entry for Coldfire's fdaddl insn.  The
> source operand had a "w" marker (modes 2-4, 7.2) whereas it should
> have had a "b" marker (modes 0, 2-4, 7.2).  gas would therefore
> treat "fdaddl %dX,%fpY" as having an invalid combination of
> operands.

OK.

> I think the wrong format was probably a cut-&-pasto from something
> like "fdaddd".  I also think it was just an isolated error; I
> checked the table and all other f*[bwls] opcodes appear to be
> correct (i.e., already use "b").  To be sure, I added tests for
> every addressing mode to mcf-fpu.s.

Thanks for your diligence!

Cheers, Ben

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]