This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Better checking of ISA/ASE/ABI options for MIPS gas

Eric Christopher wrote:
[snip]
> >>And why change the table to include default extensions for the cpu?
> >
> >To handle them the same way as the ISA. This is for ASEs which are
> >always implemented in that particular CPU.
> 
> You'll need to look through the code and make sure we aren't depending on
> the value not being zero somewhere then.

I changed the test for is_isa in mips_cpu_info_from_isa() to
(flags & MIPS_CPU_IS_ISA). mips_cpu_info_from_isa() is the only user.

> To be honest I'd just prefer another field for "default ASEs".

  a) This would bloat the table by another field to initialise.
  b) There is no generic ISA with an ASE, both uses are mutually
     exclusive.


Thiemo
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]