This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] tc-arm.c: Issue a warning for comparison instructions with an 's' suffix.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Kazu Hirata <kazu at codesourcery dot com>
- Cc: binutils at sources dot redhat dot com, Paul Brook <paul at codesourcery dot com>, nickc at redhat dot com
- Date: Thu, 04 May 2006 09:39:31 +0100
- Subject: Re: [patch] tc-arm.c: Issue a warning for comparison instructions with an 's' suffix.
- References: <200605031657.k43Gv7qh008790@sparrowhawk.codesourcery.com>
On Wed, 2006-05-03 at 17:57, Kazu Hirata wrote:
> Hi,
>
> Attached is a patch to issue a warning for comparison instructions
> like tsts, cmps, and cmns with an 's' suffix. These comparison
> instructions set the condition codes, so the 's' is redundant.
>
> Tested on arm-none-eabi. OK to apply?
>
> Kazu Hirata
>
> 2006-05-03 Kazu Hirata <kazu@codesourcery.com>
>
> * config/tc-arm.c (opcode_tag): Add OT_cinfix3_deprecated.
> (opcode_lookup): Issue a warning for opcode with
> OT_cinfix3_deprecated. Otherwise treat OT_cinfix3_deprecated
> identical to OT_cinfix3.
> (TxC3w, TC3w, tC3w): New.
> (insns): Use tC3w and TC3w for comparison instructions with
> 's' suffix.
>
> 2006-05-03 Kazu Hirata <kazu@codesourcery.com>
>
> * gas/arm/armv1.d (error-output): New.
> * gas/arm/armv1.l: New.
> * gas/arm/thumb32.d (error-output): New.
> * gas/arm/thumb32.l: New.
OK.
R.