Re: [PR 2494] PDP-11: Wrong opcode for SEC/CLC

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

Hi Nick!

On Fri, 2006-03-31 13:12:21 +0200, Sergey Ilyevsky <silyevsk@gmail.com> wrote:
> 2006/3/31, Jan-Benedict Glaw <jbglaw@lug-owl.de>:
> > I was asked to have a look at
> > http://sourceware.org/bugzilla/show_bug.cgi?id=2494 .  The bug
> > reporter complains about SEC (set carry) being used by his assembler,
> > but the final output generates CLC (clear carry.)  This preliminary
> > patch should fix it, but it's untested (and I'm not actually a PDP11
> > maintainer.)  The new opcode was taken out of my "VAX Architecture
> > Reference Manual", EY-3459E-DP, 0-932376-86-X, p. 326 (PDP-11
> > Compatibility Mode, Condition Code Operators.)
> >
> > 2006-03-31  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> >
> >         opcodes/
> >         * pdp11-opc.c (pdp11_opcodes): Correct binary representation of SEC.
> >
> > diff -Nurp src-binutils-fresh/opcodes/pdp11-opc.c src-binutils-hacked/opcodes/pdp11-opc.c
> > --- src-binutils-fresh/opcodes/pdp11-opc.c      2005-05-07 09:34:30.000000000 +0200
> > +++ src-binutils-hacked/opcodes/pdp11-opc.c     2006-03-31 10:13:39.000000000 +0200
> > @@ -50,7 +50,7 @@ const struct pdp11_opcode pdp11_opcodes[
> >    { "cl_e",    0x00ae, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> >    { "ccc",     0x00af, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> >    { "se_0",    0x00b0, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> > -  { "sec",     0x00a1, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> > +  { "sec",     0x00b1, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> >    { "sev",     0x00b2, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> >    { "se_3",    0x00b3, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> >    { "sez",     0x00b4, 0xffff, PDP11_OPCODE_NO_OPS,    PDP11_BASIC },
> Actually I don't have pdp11 as well ;-) .
> I'm using the assembler on i686.
> With the patch it works fine.

May I check this in under the obvious rule?

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fÃr einen Freien Staat voll Freier BÃrger"  | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature