This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[patch] TBB parse errors
- From: Paul Brook <paul at codesourcery dot com>
- To: binutils at sourceware dot org
- Date: Thu, 16 Mar 2006 00:49:05 +0000
- Subject: [patch] TBB parse errors
The operand parser for the TBB and TBH instructions can return FAIL without
setting an error message. The patch below ensures an appropriate error is
reported.
Ok?
Paul
2006-03-16 Paul Brook <paul@codesourcery.com>
* config/tc-arm.c (parse_tb): Set inst.error before returning FAIL.
Index: gas/config/tc-arm.c
===================================================================
RCS file: /var/cvsroot/src-cvs/src/gas/config/tc-arm.c,v
retrieving revision 1.246
diff -u -p -r1.246 tc-arm.c
--- gas/config/tc-arm.c 10 Mar 2006 17:20:30 -0000 1.246
+++ gas/config/tc-arm.c 15 Mar 2006 23:25:46 -0000
@@ -3703,7 +3706,10 @@ parse_tb (char **str)
int reg;
if (skip_past_char (&p, '[') == FAIL)
- return FAIL;
+ {
+ inst.error = _("'[' expected");
+ return FAIL;
+ }
if ((reg = arm_reg_parse (&p, REG_TYPE_RN)) == FAIL)
{
@@ -3713,7 +3719,10 @@ parse_tb (char **str)
inst.operands[0].reg = reg;
if (skip_past_comma (&p) == FAIL)
- return FAIL;
+ {
+ inst.error = _("',' expected");
+ return FAIL;
+ }
if ((reg = arm_reg_parse (&p, REG_TYPE_RN)) == FAIL)
{