This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] picojava opcodes fix
- From: Nick Clifton <nickc at redhat dot com>
- To: "Laurent D.A.M. Menten" <laurent dot menten at teledisnet dot be>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 22 Dec 2005 17:14:57 +0000
- Subject: Re: [Patch] picojava opcodes fix
- References: <437E7A69.8070107@teledisnet.be>
Hi Laurent,
Hi, here is my (small) contribution to binutils, i have checked the
opcodes of the pj architecture and found some problems mostly about
offset in jumps and _quick variations of common opcodes. As I am not
very confident with patch I simply send the 2.16 patched file. Hope it
will be usefull.
Thanks very much for making this contribution. I have updated the
PicoJava opcodes as you indicated, but in the future, if you do make any
more contributions please could I ask that you make them in the "patch"
file format and that you include a ChangeLog entry ?
For the record, I used this ChangeLog entry when applying your patch.
Cheers
Nick
opcodes/ChangeLog
2005-12-22 Laurent Menten <laurent.menten@teledisnet.be>
* pj-opc.c (jsr, ret, getstatic, putstatic, getfield, putfield,
invokevirtual, invokespecial, invokestatic, invokeinterface,
goto_w, jsr_w, ldc_quick, ldc_w_quick, ldc2_w_quick,
getfield_quick, putfield_quick, getfield2_quick, putfield2_quick,
getstatic_quick, putstatic_quick, getstatic2_quick,
putstatic2_quick, invokevirtual_quick, invokenonvirtual_quick,
invokesuper_quick, invokestatic_quick, invokeinterface_quick,
aastore_quick, new_quick, anewarray_quick, multianewarray_quick,
checkcast_quick, instanceof_quick, invokevirtiual_quick_w,
getfield_quick_w, putfield_quick_w, nonnull_quick,
agetfield_quick, aputfield_quick, agetstatic_quick,
aputstatic_quick, aldc_quick, aldc_w_quick, exit_sync_method): Fix
opcodes.