This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/hpux] Implement file_matches_executable_p


On Wed, Nov 16, 2005 at 05:14:31PM -0800, Joel Brobecker wrote:
> @@ -155,6 +144,10 @@ thread_section_p (bfd *abfd ATTRIBUTE_UN
>                    asection *sect,
>                    void *obj ATTRIBUTE_UNUSED)
>  {
> +  /* The ATTRIBUTE_UNUSED for parameter ABFD is at first sight surprising,
> +     since it appears to be used in the call to bfd_section_name.  However,
> +     bfd_section_name is a macro that doesn't use the first parameter,
> +     so the attribute above is perfectly justified.  */
>    return (strncmp (bfd_section_name (abfd, sect), ".reg/", 5) == 0);
>  }

I dislike these silly macros too.  Just use sect->name and you can do
without the comment.  Lots less typing.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]