Re: PATCH: Add double-quoted version strings

[Nick Clifton <nickc at redhat dot com>]

Hi Mark,

> OK?  

Have you tested this patch ?  I am sure that you have, but it is nice to 
mention that the testing was done, and which target(s) were tested.

The patch is OK, but I agree with Daniel that we ought to have a 
cautionary note in the linker documentation about matching demangler 
output.

Also since the point of the patch is to allow white space and globbing 
meta-characters to be matched inside the version strings, I feel that 
you ought to include these characters in your test case.  eg you could have:

  int * f<int [], unsigned long>(int [], unsigned long)

instead of:

  int f<int, char>(int, char)

Cheers
  Nick