This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix expobj size bug in the ld-cris testsuite.


See <URL:http://sourceware.org/ml/binutils/2005-07/msg00191.html>.
It's not typical (or the intent of the test) to set the size of
the referred symbol in the *referring* object.

ld/testsuite:
	* ld-cris/expdyn1.s (expobj): Set size here, at definition...
	* ld-cris/pv32.s: ...not here.
	* ld-cris/expdyn1.d, ld-cris/libdso-12.d, ld-cris/locref1.d:
	Adjust for expobj size being set at definition.

Index: expdyn1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/expdyn1.d,v
retrieving revision 1.5
diff -u -p -r1.5 expdyn1.d
--- expdyn1.d	8 Mar 2005 02:31:40 -0000	1.5
+++ expdyn1.d	12 Aug 2005 00:11:12 -0000
@@ -9,6 +9,6 @@
 
 DYNAMIC SYMBOL TABLE:
 #...
-00080... g    DF .text	00000002 expfn
-00082... g    DO .data	00000000 expobj
+00080... g    DF .text	0+2 expfn
+00082... g    DO .data	0+4 expobj
 #pass
Index: expdyn1.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/expdyn1.s,v
retrieving revision 1.1
diff -u -p -r1.1 expdyn1.s
--- expdyn1.s	31 Jan 2002 10:42:18 -0000	1.1
+++ expdyn1.s	12 Aug 2005 00:11:12 -0000
@@ -1,6 +1,7 @@
 	.data
 	.global expobj
 	.type	expobj,@object
+	.size	expobj,4
 expobj:
 	.dword 0
 
Index: libdso-12.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/libdso-12.d,v
retrieving revision 1.4
diff -u -p -r1.4 libdso-12.d
--- libdso-12.d	8 Jul 2005 06:22:01 -0000	1.4
+++ libdso-12.d	12 Aug 2005 00:11:12 -0000
@@ -14,7 +14,7 @@ DYNAMIC SYMBOL TABLE:
 #...
 0+26e g    DF \.text	0+12 dsofn4
 0+264 g    DF \.text	0+2 expfn
-0+232c g    DO \.data	0+ expobj
+0+232c g    DO \.data	0+4 expobj
 #...
 0+266 g    DF \.text	0+8 dsofn3
 #...
Index: locref1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/locref1.d,v
retrieving revision 1.5
diff -u -p -r1.5 locref1.d
--- locref1.d	23 Mar 2005 19:04:33 -0000	1.5
+++ locref1.d	12 Aug 2005 00:11:12 -0000
@@ -12,7 +12,7 @@
 SYMBOL TABLE:
 #...
 0+80076 g     F \.text	0+2 expfn
-0+82090 g     O \.data	0+ expobj
+0+82090 g     O \.data	0+4 expobj
 #...
 0+82084 g     O \.got	0+ \.hidden _GLOBAL_OFFSET_TABLE_
 #...
Index: pv32.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/pv32.s,v
retrieving revision 1.2
diff -u -p -r1.2 pv32.s
--- pv32.s	8 Jul 2005 06:22:01 -0000	1.2
+++ pv32.s	12 Aug 2005 00:11:12 -0000
@@ -14,8 +14,6 @@ pfn:
 .Lfe1:
 	.size	pfn,.Lfe1-pfn
 
-	.global	expobj
-	.size	expobj,4
 	.global dsofn
 	.type	dsofn,@function
 dsofn:

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]