Re: RFC: automagic soname generation for ibm TPF-OS

[Eric Christopher <echristo at redhat dot com>]

> ... et cetera.  This is indeed ugly.  Don't do it.  You can use "." to
> source a base file; there's dozens of examples in emulparams already. 
> That will kill the duplication.  Please add a comment to whatever file
> you source reflecting that you use it (see any of the MIPS ones for an
> example :-)
> 

Heh. Nifty, I'll look.

> > +static char tpfsoname[5];
> 
> Please, friend, lose the buffer :-)
> 
> > +/* Mangle the soname for the TPF OS system.  We only want the first
> > +   4 characters of the base output .so name only, all upper case.  
> > +   This runs into problems when the filename is < 4 characters. You
> > +   will likely get garbage.  */
> 
> ... and handle that more gracefully, please.  Just use 'A' or
> something!
> 

Yeah both of these were gross, it was admittedly a quick hack. I'll use
strlen or something and play around. :)

thanks.

-eric