This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Avoid signed/unsigned warnings in tc-arm.c

From: Zack Weinberg <zack at codesourcery dot com>
To: Khem Raj <kraj at mvista dot com>
Cc: binutils at sourceware dot org
Date: Fri, 24 Jun 2005 06:53:24 -0700
Subject: Re: PATCH: Avoid signed/unsigned warnings in tc-arm.c
References: <42BB119F.1040908@mvista.com> <42BB17EE.6000608@codesourcery.com> <42BB2D35.7090801@mvista.com>

Khem Raj wrote:

> OK. Here is revised patch based on Zack's comments. How about this one?

I can't approve this, but it looks good to me.  Just a few notes on ChangeLog
writing:

1) Don't send a ChangeLog as a diff.  By the time the patch is applied, it
won't apply cleanly.

2) Say what happened, not why.  In this case, a correct change log would read

	* tc-arm.c (struct arm_it): Make operands.reg and operands.imm signed.
	(parse_operands): Make second argument an unsigned const char *.
	(do_shift): Make Rm signed.

zw

Follow-Ups:
- Re: PATCH: Avoid signed/unsigned warnings in tc-arm.c
  - From: Doug Evans
- Re: PATCH: Avoid signed/unsigned warnings in tc-arm.c
  - From: Khem Raj

References:
- PATCH: Avoid signed/unsigned warnings in tc-arm.c
  - From: Khem Raj
- Re: PATCH: Avoid signed/unsigned warnings in tc-arm.c
  - From: Zack Weinberg
- Re: PATCH: Avoid signed/unsigned warnings in tc-arm.c
  - From: Khem Raj

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]