This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: x86-64 large data sections updated


On Wed, Jun 15, 2005 at 12:13:15AM +0200, Jan Hubicka wrote:
> *************** get_program_header_size (bfd *abfd)
> *** 4593,4598 ****
> --- 4593,4607 ----
>         segs += 2;
>       }
>   
> +   if (bfd_get_section_by_name (abfd, ".ldata") != NULL
> +       || bfd_get_section_by_name (abfd, ".lrodata") != NULL
> +       || bfd_get_section_by_name (abfd, ".lbss") != NULL)

This shouldn't be in elf.c.  And you can need 2 segments, not
just one.

> + elf64_x86_64_elf_section_from_bfd_section (bfd *abfd ATTRIBUTE_UNUSED,
> + 					asection *sec, int *retval)
> + {
> +   if (strcmp (bfd_get_section_name (abfd, sec), ".lcommon") == 0
> +       || strcmp (bfd_get_section_name (abfd, sec), ".lbss") == 0)
> +     {
> +       *retval = SHN_X86_64_LCOMMON;

You never ever want this.  COMMON does not mean the same thing as bss.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]