This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATH: Restore file cache for bfd_openr

From: Mark Mitchell <mark at codesourcery dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: binutils at sources dot redhat dot com
Date: Wed, 08 Jun 2005 21:48:49 -0700
Subject: Re: PATH: Restore file cache for bfd_openr
References: <200506082243.j58MhLss030145@sethra.codesourcery.com> <20050609042519.GY2677@bubble.grove.modra.org>

Alan Modra wrote:

On Wed, Jun 08, 2005 at 03:43:21PM -0700, Mark Mitchell wrote:

* opncls.c (bfd_openr): Call bfd_set_cacheable on returned BFDs.
I think it makes sense to do this in bfd_fopen instead, if fd != -1.
ie. Make your new bfd_fopen function default to the auto-close/open
behaviour.  Thoughts?

Makes sense to me. May I check in that variation, assuming the same testing shows that it works OK?

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

Follow-Ups:
- Re: PATH: Restore file cache for bfd_openr
  - From: Alan Modra

References:
- PATH: Restore file cache for bfd_openr
  - From: Mark Mitchell
- Re: PATH: Restore file cache for bfd_openr
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]