This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [RFA:] ar test failure fix
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sourceware dot org
- Date: Wed, 8 Jun 2005 05:26:37 +0200
- Subject: Re: [RFA:] ar test failure fix
> Date: Wed, 8 Jun 2005 05:20:08 +0200
> From: Hans-Peter Nilsson <hp@axis.com>
> > * opncls.c (bfd_fopen): Don't set bfd_error unconditionally.
>
> But not the same in bfd_fdopenr?
>
> It it was me, I'd save the previous bfd_error at function start,
> and restore before successful exit.
Uh, that'd be equivalent to just setting it when needed, of
course. Still, removing the unconditional setting in
bfd_fdopenr (before it calls bfd_fopen, doh) seems right. I'd
call it obvious if it wasn't that it isn't anymore.
brgds, H-P