This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [RFA:] ar test failure fix
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: amodra at bigpond dot net dot au
- Cc: hans-peter dot nilsson at axis dot com, mark at codesourcery dot com, binutils at sourceware dot org
- Date: Wed, 8 Jun 2005 05:20:08 +0200
- Subject: Re: [RFA:] ar test failure fix
> Date: Wed, 8 Jun 2005 12:45:43 +0930
> From: Alan Modra <amodra@bigpond.net.au>
> On Wed, Jun 08, 2005 at 05:01:57AM +0200, Hans-Peter Nilsson wrote:
> > My patch is for bfd_fopen which only did that on error, not bfd_fdopenr.
> >
> > So there *is* a latent bug.
>
> Well, there was. I'm applying this fix instead of yours.
>
> * opncls.c (bfd_fopen): Don't set bfd_error unconditionally.
But not the same in bfd_fdopenr?
It it was me, I'd save the previous bfd_error at function start,
and restore before successful exit.
brgds, H-P