This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[RFA:] ar test failure fix
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sourceware dot org
- Cc: mark at codesourcery dot com
- Date: Wed, 8 Jun 2005 04:44:17 +0200
- Subject: [RFA:] ar test failure fix
Mark, did you really run the testsuite after your bfd-fopen ABI
changes, in a *clean* directory (no partial test-results or
left-over files)? My autotester for cris-elf did, and got
(after the recent new-port-commit debacle and switch braino was
fixed, that is):
Running /h/hp/binutils/cvs_latest/src/binutils/testsuite/binutils-all/ar.exp ...
FAIL: ar symbol table
FAIL: ar argument parsing
Looking closer, it seems you added a call to bfd_error but
didn't make a corresponding clearing call.
Here's a patch that fixes the failures, no regressions. I guess
the test-suite could do with removing files after runs.
Ok to commit?
bfd:
* opncls.c (bfd_fopen): Clear bfd error status just before
successful exit.
Index: opncls.c
===================================================================
RCS file: /cvs/src/src/bfd/opncls.c,v
retrieving revision 1.35
diff -u -p -r1.35 opncls.c
--- opncls.c 8 Jun 2005 00:00:05 -0000 1.35
+++ opncls.c 8 Jun 2005 02:13:06 -0000
@@ -200,6 +200,7 @@ bfd_fopen (const char *filename, const c
}
nbfd->opened_once = TRUE;
+ bfd_set_error (bfd_error_no_error);
return nbfd;
}
brgds, H-P