This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] i386 vxworks shared libraries - second try


Paul Brook <paul@codesourcery.com> writes:

>  	  /* UnixWare sets the entsize of .plt to 4, although that doesn't
>  	     really seem like the right value.  */
>  	  elf_section_data (htab->splt->output_section)
>  	    ->this_hdr.sh_entsize = 4;
> +
> +	  /* Correct the .rel.plt.unloaded relocations.  */
> +	  if (htab->is_vxworks && !info->shared)
> +	    {
> +	      int num_plts = (htab->splt->size / PLT_ENTRY_SIZE) - 1;
> +	      char *p;
> +
> +	      p = htab->srelplt2->contents;

This is causing build failures with gcc4.

../../bfd/elf32-i386.c: In function 'elf_i386_finish_dynamic_sections':
../../bfd/elf32-i386.c:3448: warning: pointer targets in assignment differ in signedness
../../bfd/elf32-i386.c:3457: warning: pointer targets in passing argument 2 of 'bfd_elf32_swap_reloc_in' differ in signedness
../../bfd/elf32-i386.c:3459: warning: pointer targets in passing argument 3 of 'bfd_elf32_swap_reloc_out' differ in signedness
../../bfd/elf32-i386.c:3462: warning: pointer targets in passing argument 2 of 'bfd_elf32_swap_reloc_in' differ in signedness
../../bfd/elf32-i386.c:3464: warning: pointer targets in passing argument 3 of 'bfd_elf32_swap_reloc_out' differ in signedness

Checked in as obvious.

Andreas.

2005-05-11  Andreas Schwab  <schwab@suse.de>

	* elf32-i386.c (elf_i386_finish_dynamic_sections): Fix signedness
	warning.

--- bfd/elf32-i386.c	06 Mai 2005 11:12:27 +0200	1.137
+++ bfd/elf32-i386.c	11 Mai 2005 10:56:41 +0200	
@@ -3443,7 +3443,7 @@ elf_i386_finish_dynamic_sections (bfd *o
 	  if (htab->is_vxworks && !info->shared)
 	    {
 	      int num_plts = (htab->splt->size / PLT_ENTRY_SIZE) - 1;
-	      char *p;
+	      unsigned char *p;
 
 	      p = htab->srelplt2->contents;
 	      if (info->shared)

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]