This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: use hashtab for pseudo op table


Hi Alan,

I agree - Ben, what is your motivation for removing hash.c ?

Probably because I was talking to Ben a week or so ago, and mentioned
that it's silly that we have so many hash table implementations.  We
have libiberty/hashtab.c, bfd/hash.c, and gas/hash.c.  Some of bfd
already uses libiberty/hashtab.c due to it's rather nice auto-resize,
and more of bfd should.  ie. I see libiberty/hashtab.c as the way of
the future.

Well removing multiple implementations of the same thing is certainly good.


I guess the question comes down to - should bfd keep or re-implement its own hashtab code to be used everywhere in binutils or should the one from libiberty be used ? Zack pointed out the performance penalty of using libiberty's code, and I would like to get a feel for whether this would be a serious hindrance to using it.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]