This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: HEAD b0rked re coff-tic80?
- From: Nick Clifton <nickc at redhat dot com>
- To: Dave Korn <dave dot korn at artimi dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 26 Apr 2005 17:57:16 +0100
- Subject: Re: HEAD b0rked re coff-tic80?
- References: <SERRANOEbjkyqU7a0xt0000011b@SERRANO.CAM.ARTIMI.COM>
Hi Dave,
Just did a cvsup not half an hour ago. After configuring with
--enable-targets=all, (which I don't usually bother with), my build failed
with....
In file included from /usr/build/binutils-src/src/bfd/coff-tic80.c:31:
/usr/build/binutils-src/src/include/coff/tic80.h:71:1: "_CONST" redefined
In file included from /usr/include/stdio.h:29,
from /usr/build/binutils-src/src/bfd/sysdep.h:33,
from /usr/build/binutils-src/src/bfd/coff-tic80.c:29:
/usr/include/_ansi.h:30:1: this is the location of the previous definition
This does not happen for me, but I can certainly see how the problem
might arise. Since _CONST is not actually used in the tic80 specific
sources the simplest thing seems to be to remove it. So... please could
you try out the patch and let me know if you have any problems with it.
Cheers
Nick
Index: include/coff/tic80.h
===================================================================
RCS file: /cvs/src/src/include/coff/tic80.h,v
retrieving revision 1.2
diff -c -3 -p -r1.2 tic80.h
*** include/coff/tic80.h 14 Mar 2001 02:27:44 -0000 1.2
--- include/coff/tic80.h 26 Apr 2005 16:56:58 -0000
*************** struct external_scnhdr
*** 67,77 ****
--- 67,81 ----
#define _TEXT ".text"
#define _DATA ".data"
#define _BSS ".bss"
+ #if 0 /* The following are not used in the binutils sources and the
definition
+ of _CONST can clash with a definition provided by the system header
+ file _ansi.h */
#define _CINIT ".cinit"
#define _CONST ".const"
#define _SWITCH ".switch"
#define _STACK ".stack"
#define _SYSMEM ".sysmem"
+ #endif
#define SCNHDR struct external_scnhdr
#define SCNHSZ 40