This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: patch breaks libgloss builds
> This fixes the problem and I've run the test suite for mips64el-linux-gnu
> successfully, but I don't feel that fulfils testing terribly well. A
> proper test case for "li"/"dli" should be desirable -- I'll have a look at
> it later.
>
Running a test of gcc with a combined tree for mipsisa64-elf ferrets out
a lot of problems since the unpredictable bits are set in the simulator
and libgloss uses the assembler macros for startup code.
> Also it seems we call normalize_constant_expr() a little bit too
> extensively -- perhaps a few of these calls could be removed. I think we
> have a few explicit sign-extensions elsewhere, too, and some of them could
> actually fit into one of these normalize_*() calls.
>
> 2005-04-15 Maciej W. Rozycki <macro@linux-mips.org>
>
> * config/tc-mips.c (normalize_constant_expr): Don't check for
> HAVE_32BIT_GPRS.
> (check_absolute_expr): Only call normalize_constant_expr() if
> HAVE_32BIT_GPRS.
> (mips_ip): Likewise.
>
> * config/tc-mips.c (check_absolute_expr): Fix formatting.
If you haven't checked it in yet OK to do so for mainline and 2.16.
-eric