This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols


Daniel Jacobowitz wrote:
On Sun, Mar 27, 2005 at 09:25:49PM +0100, Julian Brown wrote:

In the interest of preserving existing behaviour, I have fixed this by adding a new disassemble_info hook which allows the symbol table used for disassembly to have a target-specific hook for altering each symbol (or remove it) in the remove_useless_symbols function. This sets the BSF_FUNCTION flag for mapping symbols, which makes things behave the way they used to, and possibly provides useful functionality for other platforms as well.

How about checking bfd_is_target_special_symbol in remove_useless_syms?

To remove the mapping symbols altogether? That would make sense, but the output of objdump would still be altered then -- my patch doesn't actually remove the mapping symbols in remove_useless_symbols, just munges their type. This was the best way I could come up with to preserve existing behaviour without affecting other platforms, but I suspect it might be trying too hard (it is "only" disassembled output which is affected, presumably meant for human consumption).


Julian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]