This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: gas/config/tc-tic54x.c's use of macro_struct and formal_struct

From: Nick Clifton <nickc at redhat dot com>
To: Jan Beulich <JBeulich at novell dot com>
Cc: twall at alum dot mit dot edu, binutils at sources dot redhat dot com
Date: Wed, 09 Mar 2005 12:56:28 +0000
Subject: Re: gas/config/tc-tic54x.c's use of macro_struct and formal_struct
References: <s22ecbc2.084@emea1-mh.id2.novell.com>

Hi Jan,

As I'm intending to add one or two elements to macro_struct (to allow
.purgem to free the memory allocated by .macro) I'd like to understand
what, if any, reasons there are for this file, in function
tic54x_macro_info, to redeclare these two structures instead of using
them (or even better their typedef equivalents) from the already
included macro.h.

As far as I can tell this was an ill-advised piece of coding. The typedefs from macro.h should have been used as you suggested. Please feel free to contribute a patch to do just this.

Cheers
  Nick

Follow-Ups:
- Re: gas/config/tc-tic54x.c's use of macro_struct and formal_struct
  - From: Timothy Wall

References:
- gas/config/tc-tic54x.c's use of macro_struct and formal_struct
  - From: Jan Beulich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]