This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64: second .xdata fix (was Re: IA64 gas is broken)
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: "H. J. Lu" <hjl at lucon dot org>, binutils at sources dot redhat dot com
- Date: Mon, 07 Mar 2005 12:24:06 -0800
- Subject: Re: [PATCH] ia64: second .xdata fix (was Re: IA64 gas is broken)
- References: <s22329d7.031@emea1-mh.id2.novell.com>
On Mon, 2005-02-28 at 06:25, Jan Beulich wrote:
> * config/tc-ia64.c (parse_section_name): Rename to...
> (cross_section): In addition to separating the name from the
> rest of
> the arguments, also carry out the operation.
> ...
OK.
Though I find it a little funny that you are adding testcases for odd
section names. These aren't allowed by the IA-64 assembler manual,
which only allows the same identifiers we allow for variables and
labels. The fact that we do accept things like .xreal+2 is more an
accident of implementation than intent. Though considering that it is
obj-elf.c that would have to change, it seems reasonable to work around
this in tc-ia64.c by allowing them. We shouldn't imply that support for
them is required though. Maybe the testcase could have a comment
pointing out that these aren't valid IA-64 section names, but we test
them because we got them wrong at one point.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com