This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] more ARC opcodes cleanups.
- From: Nick Clifton <nickc at redhat dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at codito dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 03 Mar 2005 15:03:22 +0000
- Subject: Re: [PATCH] more ARC opcodes cleanups.
- References: <422705D4.2070005@codito.com>
Hi Ramana,
These are more small cleanups in the backend for the disassembler for
ARC. I have just named values given to the decode class as macros and
used them . Also removed a redundant case in the switch for the
decodingClass.
Tested as arc-elf32 cross with no regressions on i686-linux
Can I commit this as obvious ?
Sorry no.
There are three problems:
1. You are using a set of #define's for the arithmetic classes, which
is better than the straight constants that were being used before, but
for something like this an enum is the correct way to go.
2. When you add comments, please make sure that they follow the
guidelines for comment format. In this case they should be treated as
full sentences and end with a full stop followed by two spaces before
the */ characters.
3. You appear to be adding in extra blank lines for no really good
reason.
If you would like to fix these issues then you may apply the patch.
Cheers
Nick