This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] MIPS gas/ld test suite portability fixes
Maciej W. Rozycki wrote:
> On Tue, 22 Feb 2005, Thiemo Seufer wrote:
>
> > > gas/testsuite/:
> > > 2005-02-22 Maciej W. Rozycki <macro@mips.com>
> > >
> > > * mips/elf-rel-got-n32.d: Pass -march=mips3 to gas to select a
> > > 64-bit architecture.
> >
> > We should probably change gas instead to imply MIPS III for -n32/-64.
> > It is the required minimum for NewABI anyways.
>
> Hmm, in this case what about configurations that default to mips32 or
> mips32r2? I wonder if -n32/-64 shouldn't actually imply the lowest 64-bit
> ISA higher than the default. That would currently mean mips64 and
> mips64r2 for the mentioned cases, respectively, and mips3 otherwise.
I meant something like:
--- tc-mips.c 18 Feb 2005 22:12:50 -0000 1.284
+++ tc-mips.c 22 Feb 2005 21:54:59 -0000
@@ -10652,7 +10694,11 @@ mips_after_parse_args (void)
}
if (arch_info == 0)
- arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
+ {
+ arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
+ if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
+ arch_info->isa = ISA_MIPS3;
+ }
if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))
as_bad ("-march=%s is not compatible with the selected ABI",
(This fails to compile because arch_info is a constant.)
Thiemo