Re: PATCH: Test the just built windres/dlltool only

[Nick Clifton <nickc at redhat dot com>]

Hi H. J.

> My PATH has binaries for my host machine, which are irrelevant to the
> target for my binutils built tree. I don't think
>
> # configure
> # make
> # make check
>
> should test any of my install binaries. "make check" should assume
> my installed binaries are OK. 

But by this argument, your patch ought to be extended to all of the 
programs checked in the default.exp file, not just windres and dlltool.

Plus I do not think that it is always reasonable to assume that 
installed binaries are OK.  Users should be able to test them if they 
are worried that they contain bugs, or if they want to compare the 
behaviour of an installed set of tools against another set.

> I still haven't seen a reasonable reason
> for "make check" to test the installed binaries.

Perhaps what you really want is a way to disable the testsuite from 
searching through $PATH for binaries to test.  So that if, and only if, 
you are sure that you do not want to check any installed binaries, then 
you could enable this magic option and the testsuite would never check 
anything but binaries in build trees.

I would suggest creating your own version of findfile which when it 
cannot find the file checks to see whether names-in-PATH is OK, and if 
not then just returns "" and otherwise returns the transformed name. 
Then replace all uses of findfile (in default.exp) with this version.

Cheers
  Nick