This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix "FAIL: objcopy (simple copy)" for tic54x-coff

Hi Alan, Hi H.J.

	* coffcode.h (coff_write_relocs): Clear the r_reserved field
	if COFF_REL_HAS_R_RESERVED is defined before swapping out
	relocation.

This should really be done by defining a coff_SWAP_reloc_out function
for these targets.

I agree with Alan - why not define the SWAP_OUT_RELOC_EXTRA macro for the tic54x-coff port and have that write out zeros for the r_reserved field ?

Cheers
  Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]