Re: [PATCH] MIPS/ELF: Fixes for external R_MIPS_LITERAL relocations

[Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>]

Maciej W. Rozycki wrote:
> On Wed, 9 Feb 2005, Thiemo Seufer wrote:
> 
> > > 2005-02-07  Maciej W. Rozycki  <macro@mips.com>
> > > 
> > > 	* elf32-mips.c (_bfd_mips_elf32_gprel16_reloc): Reject 
> > > 	R_MIPS_LITERAL relocations for external symbols.
> > > 	* elf64-mips.c (mips_elf64_literal_reloc): Likewise.
> > > 	* elfn32-mips.c (mips_elf_literal_reloc): Likewise.
> > > 
> > >  OK to apply (or should we have mips_elf_literal_reloc() calling 
> > > _bfd_mips_elf32_gprel16_reloc() after the check for elf32-mips.c now)?
> > 
> > The idea was to give R_MIPS_LITERAL its own handler function because its
> > values are supposed to get merged. I didn't do so for elf32-mips.c
> > because there's a weird special casing of _bfd_mips_elf32_gprel16_reloc
> > in elfxx-mips.c
> 
>  Well, that looks scary and fragile and is probably well worth 
> investigation.
> 
> > Btw, R_MIPS16_GPREL seems also to have inconsistencies.
> 
>  What specifically?  I'm currently having a look into the MIPS16 
> relocation stuff, so I may as well investigate this problem.

This was already addressed.

>  Finally, what about the patch -- is it OK or is there anything wrong with 
> it?

The patch is ok, I only hoped for some means to get rid of that scary
part in elfxx-mips.c. :-)


Thiemo