This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ia64 bundling issues


On Thu, 2005-01-27 at 23:52, Jan Beulich wrote:
> Actually, I'd rather not do this. Since similarly (when it will become
> necessary) switching
> from MII to MI;I would be permissible, and since, resulting from
> whatever potential future
> change, user_template == 5 would be acceptable, too, I'd rather stay
> with the way I
> coded this.

I still think it is cryptic.  You are right that it nicely handles the
0/1 case as well as the current 4/5 case, but my point is that it
doesn't work for any of the other 12 cases, and it isn't obvious that it
will get them wrong.  At least it makes more sense with the comment
added.

I guess I can live with it.  I am more interested in having the rest of
the fixes than in arguing about this one line of code.

The patch is OK.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]