This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFA: elf.sc patch (was Re: RFA: MIPS's _gp symbol and the new orphan-placement code)
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Richard Sandiford <rsandifo at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Sun, 23 Jan 2005 00:01:59 +1030
- Subject: Re: RFA: elf.sc patch (was Re: RFA: MIPS's _gp symbol and the new orphan-placement code)
- References: <87hdo2111f.fsf@redhat.com> <20041107224825.GH21740@bubble.modra.org> <20041108011636.GA21482@nevyn.them.org> <20041108025455.GI21740@bubble.modra.org> <87r7mxa0rw.fsf@redhat.com> <87sm4td9ru.fsf_-_@redhat.com>
On Sat, Jan 22, 2005 at 10:43:17AM +0000, Richard Sandiford wrote:
> * scripttempl/elf.sc: Insert ". = .;" before OTHER_GOT_SYMBOLS.
I'd prefer you do this by modifying OTHER_GOT_SYMBOLS in elf32bmip.sh
and elf32bmipn32-defs.sh, perhaps with a comment. OTHER_GOT_SYMBOLS
may not always be used to only define symbols, and placing ".=.;" in the
source close to where you assign a symbol value might clue future
hackers to guard other random symbol assignments. Also, four other
scripts use OTHER_GOT_SYMBOLS, so if you change elf.sc you really ought
to change them too. Patch to emulparams/* preapproved.
--
Alan Modra
IBM OzLabs - Linux Technology Centre